From reviews-return-42990-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 15 18:54:01 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 77F7D190C4 for ; Mon, 15 Aug 2016 18:54:01 +0000 (UTC) Received: (qmail 56248 invoked by uid 500); 15 Aug 2016 18:54:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56225 invoked by uid 500); 15 Aug 2016 18:54:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56210 invoked by uid 99); 15 Aug 2016 18:54:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 18:54:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 331E72CB416; Mon, 15 Aug 2016 18:54:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6657992583100861737==" MIME-Version: 1.0 Subject: Re: Review Request 51102: Supported nested ContainerID. From: Gilbert Song To: Kevin Klues , Benjamin Hindman , Gilbert Song Cc: Jie Yu , mesos Date: Mon, 15 Aug 2016 18:54:00 -0000 Message-ID: <20160815185400.17019.47472@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51102/ X-Sender: Gilbert Song X-ReviewBoard-ShipIt: 1 References: <20160815184239.17020.69461@reviews.apache.org> In-Reply-To: <20160815184239.17020.69461@reviews.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============6657992583100861737== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51102/#review145785 ----------------------------------------------------------- Fix it, then Ship it! include/mesos/mesos.proto (line 92) Please add it to v1/mesos.proto as well. - Gilbert Song On Aug. 15, 2016, 11:42 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51102/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 11:42 a.m.) > > > Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Introduced an optional 'parent' field in ContainerID so it can encode > nesting relationship. > > > Diffs > ----- > > include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 > > Diff: https://reviews.apache.org/r/51102/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============6657992583100861737==--