From reviews-return-42967-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 15 17:18:55 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3940319CA1 for ; Mon, 15 Aug 2016 17:18:55 +0000 (UTC) Received: (qmail 55727 invoked by uid 500); 15 Aug 2016 17:18:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 55694 invoked by uid 500); 15 Aug 2016 17:18:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55675 invoked by uid 99); 15 Aug 2016 17:18:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 17:18:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C06522CBBE3; Mon, 15 Aug 2016 17:18:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8189578242598444060==" MIME-Version: 1.0 Subject: Re: Review Request 51059: Made `ExecutorInfo.command` optional. From: Avinash sridharan To: James DeFelice , Jie Yu , Benjamin Mahler Cc: Avinash sridharan , Vinod Kone , mesos Date: Mon, 15 Aug 2016 17:18:53 -0000 Message-ID: <20160815171853.17020.61808@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Avinash sridharan X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51059/ X-Sender: Avinash sridharan References: <20160812230801.1723.57589@reviews.apache.org> In-Reply-To: <20160812230801.1723.57589@reviews.apache.org> Reply-To: Avinash sridharan X-ReviewRequest-Repository: mesos --===============8189578242598444060== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/#review145771 ----------------------------------------------------------- src/master/validation.cpp (line 586) Maybe add a JIRA, if we have one, for `TaskGroup` validation over here. - Avinash sridharan On Aug. 12, 2016, 11:08 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51059/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:08 p.m.) > > > Review request for mesos, Benjamin Mahler, James DeFelice, and Jie Yu. > > > Bugs: MESOS-6036 > https://issues.apache.org/jira/browse/MESOS-6036 > > > Repository: mesos > > > Description > ------- > > This is done to allow schedulers to use `ExecutorInfo` with just > `executor_id` set. This is a requirement for the upcoming support > for `TaskGroup` semantics. > > Note that in this patch, TASK_ERROR is returned when > `ExecutorInfo.command` is unset to keep the existing semantics for > `LAUNCH` offer operation. This might change when we add `LAUNCH_GROUP` > operation. > > > Diffs > ----- > > include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 > include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 > src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c > src/tests/master_validation_tests.cpp 9eb82a569f7c48caa96d4d54a93b199ccac74385 > > Diff: https://reviews.apache.org/r/51059/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============8189578242598444060==--