From reviews-return-42894-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Aug 14 18:37:05 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C87319CE1 for ; Sun, 14 Aug 2016 18:37:05 +0000 (UTC) Received: (qmail 23335 invoked by uid 500); 14 Aug 2016 18:37:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23305 invoked by uid 500); 14 Aug 2016 18:37:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23289 invoked by uid 99); 14 Aug 2016 18:37:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Aug 2016 18:37:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3E7451DD49B; Sun, 14 Aug 2016 18:37:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6863397426955016387==" MIME-Version: 1.0 Subject: Re: Review Request 49828: Added default methods implementations for `Subsystem` base class. From: haosdent huang To: Jie Yu , Zhengju Sha , Gilbert Song , Qian Zhang Cc: Mesos ReviewBot , haosdent huang , mesos Date: Sun, 14 Aug 2016 18:37:04 -0000 Message-ID: <20160814183704.17019.94495@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49828/ X-Sender: haosdent huang References: <20160811141903.1723.98960@reviews.apache.org> In-Reply-To: <20160811141903.1723.98960@reviews.apache.org> Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============6863397426955016387== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ ----------------------------------------------------------- (Updated Aug. 14, 2016, 6:37 p.m.) Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. Changes ------- Rebase. Bugs: MESOS-5039 https://issues.apache.org/jira/browse/MESOS-5039 Repository: mesos Description ------- Added default methods implementations for `Subsystem` base class. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 Diff: https://reviews.apache.org/r/49828/diff/ Testing ------- Thanks, haosdent huang --===============6863397426955016387==--