From reviews-return-42858-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Aug 13 20:07:10 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A62019CDE for ; Sat, 13 Aug 2016 20:07:09 +0000 (UTC) Received: (qmail 2830 invoked by uid 500); 13 Aug 2016 20:07:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 2801 invoked by uid 500); 13 Aug 2016 20:07:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 2782 invoked by uid 99); 13 Aug 2016 20:07:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Aug 2016 20:07:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 29A392CBB83; Sat, 13 Aug 2016 20:07:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5752305256434834433==" MIME-Version: 1.0 Subject: Re: Review Request 51068: Prevent memory leaks From: Neil Conway To: Neil Conway , Aaron Wood , mesos Date: Sat, 13 Aug 2016 20:07:08 -0000 Message-ID: <20160813200708.7516.67879@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51068/ X-Sender: Neil Conway References: <20160813080857.1724.97170@reviews.apache.org> In-Reply-To: <20160813080857.1724.97170@reviews.apache.org> Reply-To: Neil Conway X-ReviewRequest-Repository: mesos --===============5752305256434834433== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review145706 ----------------------------------------------------------- Hi Aaron, Awesome, thanks for your contribution! Two quick suggestions: (1) Is there a workload/tool that repros the memory leak? e.g., it would be good to be able to say that "when you do X (e.g., run unit test X) under `valgrind --leak-check=full`, there was previously a memory leak of X bytes; with these changes, the leak is instead Y bytes." (2) When contributing to Mesos, we try to encourage people to find a shepherd (Mesos committer) to work with to get your changes committed (https://mesos.apache.org/documentation/latest/submitting-a-patch/). I've pinged a few committers, so hopefully someone volunteers -- otherwise, you can find people in the `#dev` channel on Slack, IRC, or the dev mailing list. - Neil Conway On Aug. 13, 2016, 8:08 a.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51068/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2016, 8:08 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > This should prevent any of the promises that are created in the various ZookeeperProcess class methods from leaking memory. > > > Diffs > ----- > > docs/contributors.yaml 3f06000 > src/zookeeper/zookeeper.cpp e105377 > > Diff: https://reviews.apache.org/r/51068/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Aaron Wood > > --===============5752305256434834433==--