From reviews-return-42800-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 12 22:02:50 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D2A119AE3 for ; Fri, 12 Aug 2016 22:02:50 +0000 (UTC) Received: (qmail 80215 invoked by uid 500); 12 Aug 2016 22:02:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 80184 invoked by uid 500); 12 Aug 2016 22:02:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 80162 invoked by uid 99); 12 Aug 2016 22:02:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Aug 2016 22:02:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9430E2CB826; Fri, 12 Aug 2016 22:02:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0441741705318942799==" MIME-Version: 1.0 Subject: Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction. From: Joseph Wu To: Joris Van Remoortere , Artem Harutyunyan , Vinod Kone , Greg Mann Cc: Joseph Wu , mesos Date: Fri, 12 Aug 2016 22:02:44 -0000 Message-ID: <20160812220244.1724.66201@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50621/ X-Sender: Joseph Wu References: <20160809010748.6951.88677@reviews.apache.org> In-Reply-To: <20160809010748.6951.88677@reviews.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============0441741705318942799== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/ ----------------------------------------------------------- (Updated Aug. 12, 2016, 3:02 p.m.) Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes ------- Change dependency. Bugs: MESOS-3910 https://issues.apache.org/jira/browse/MESOS-3910 Repository: mesos Description ------- Moves the destructor code in `HttpProxy` into the `Process::finalize` function. And changes the `HttpProxy`s termination logic to terminate via `UPID` which guards against double-termination. Removes some unused initialization code, too. Diffs ----- 3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 Diff: https://reviews.apache.org/r/50621/diff/ Testing ------- make (More testing done later in the chain) Thanks, Joseph Wu --===============0441741705318942799==--