From reviews-return-42787-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 12 20:15:19 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A6BC1970C for ; Fri, 12 Aug 2016 20:15:19 +0000 (UTC) Received: (qmail 56901 invoked by uid 500); 12 Aug 2016 20:15:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56873 invoked by uid 500); 12 Aug 2016 20:15:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56855 invoked by uid 99); 12 Aug 2016 20:15:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Aug 2016 20:15:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B14852CB978; Fri, 12 Aug 2016 20:15:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8842373618276727465==" MIME-Version: 1.0 Subject: Re: Review Request 43558: Sped up ExamplesTest.PersistentVolumeFramework. From: Benjamin Mahler To: Jie Yu , Benjamin Mahler , Alexander Rukletsov Cc: haosdent huang , mesos Date: Fri, 12 Aug 2016 20:15:18 -0000 Message-ID: <20160812201518.1723.3938@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43558/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20160812143845.1723.41056@reviews.apache.org> In-Reply-To: <20160812143845.1723.41056@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============8842373618276727465== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review145655 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Mahler On Aug. 12, 2016, 2:38 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43558/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 2:38 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jie Yu. > > > Bugs: MESOS-4663 > https://issues.apache.org/jira/browse/MESOS-4663 > > > Repository: mesos > > > Description > ------- > > By lowering `tasks_per_shard`, this patch reduces the tasks lauched to > speed up `ExamplesTest.PersistentVolumeFramework`. > > > Diffs > ----- > > src/examples/persistent_volume_framework.cpp fe2837cfffb6dd251ccb9c93197f623d0c55fb36 > > Diff: https://reviews.apache.org/r/43558/diff/ > > > Testing > ------- > > Repeat test in CentOS 7.1 > ``` > sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 --gtest_break_on_failure > ``` > > Before apply the patch, > > ``` > [ OK ] ExamplesTest.PersistentVolumeFramework (3505 ms) > [----------] 1 test from ExamplesTest (3510 ms total) > ``` > > After apply the patch, > > ``` > [ OK ] ExamplesTest.PersistentVolumeFramework (2479 ms) > [----------] 1 test from ExamplesTest (2483 ms total) > ``` > > > Thanks, > > haosdent huang > > --===============8842373618276727465==--