From reviews-return-42741-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 12 09:15:46 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8292C19EF3 for ; Fri, 12 Aug 2016 09:15:46 +0000 (UTC) Received: (qmail 98346 invoked by uid 500); 12 Aug 2016 09:10:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 98325 invoked by uid 500); 12 Aug 2016 09:10:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 98029 invoked by uid 99); 12 Aug 2016 09:10:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Aug 2016 09:10:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 869B12CB7F5; Fri, 12 Aug 2016 09:10:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5941280911233956226==" MIME-Version: 1.0 Subject: Re: Review Request 51014: Removed one blank space in allocator benchmark test 'DeclineOffers'. From: Mesos ReviewBot To: Benjamin Mahler Cc: Mesos ReviewBot , Guangya Liu , mesos Date: Fri, 12 Aug 2016 09:10:57 -0000 Message-ID: <20160812091057.1724.35827@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51014/ X-Sender: Mesos ReviewBot References: <20160811233018.1724.86555@reviews.apache.org> In-Reply-To: <20160811233018.1724.86555@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============5941280911233956226== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51014/#review145602 ----------------------------------------------------------- Patch looks great! Reviews applied: [50693, 50695, 50866, 50868, 51014] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 11, 2016, 11:30 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51014/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 11:30 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Removed one blank space in allocator benchmark test 'DeclineOffers'. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77 > > Diff: https://reviews.apache.org/r/51014/diff/ > > > Testing > ------- > > make > make check > > After fix: > ``` > [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 3011us > Added 1000 agents in 445145us > round 0 allocate() took 161072us to make 0 offers after filtering 1000 offers > round 1 allocate() took 157639us to make 0 offers after filtering 1000 offers > ``` > > > Thanks, > > Guangya Liu > > --===============5941280911233956226==--