> On Aug. 11, 2016, 8:17 p.m., Jie Yu wrote: > > docs/cni.md, lines 241-243 > > > > > > This is inconsistent with the previous paragraph. > > > > ``` > > Whenever the `network/cni` isolator needs to attach a container to a CNI network, it reads the corresponding configuration from the disk and invokes the appropriate plugin with the specified JSON configuration. > > ``` > > > > Why restart is needed? I think the current semantics is not good. We should keep an in-memory copy of CNI config. Any config change should require an agent restart. I see your point. For modification we don't need a restart since the change in the CNI config will be picked up when a new container is launched on that network, since it will be read from the disk. Let me re-write this piece. I do agree that the semantics for add and modify now become different and keeping an in-memory copy will keep it consistent. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/#review145553 ----------------------------------------------------------- On Aug. 10, 2016, 1:41 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50941/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 1:41 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5985 > https://issues.apache.org/jira/browse/MESOS-5985 > > > Repository: mesos > > > Description > ------- > > Added a section on "Adding/Modifying/Deleting CNI configuration". > > > Diffs > ----- > > docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 > > Diff: https://reviews.apache.org/r/50941/diff/ > > > Testing > ------- > > Launched the webiste and verified the changes. > > > Thanks, > > Avinash sridharan > >