From reviews-return-42322-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 5 11:45:13 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43C3D19C8D for ; Fri, 5 Aug 2016 11:45:13 +0000 (UTC) Received: (qmail 23253 invoked by uid 500); 5 Aug 2016 11:45:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23222 invoked by uid 500); 5 Aug 2016 11:45:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23203 invoked by uid 99); 5 Aug 2016 11:45:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 11:45:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A722E2BFED9; Fri, 5 Aug 2016 11:45:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2225704611625879138==" MIME-Version: 1.0 Subject: Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check. From: =?utf-8?q?Gast=C3=B3n_Kleiman?= To: Adam B , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler , Alexander Rukletsov Cc: haosdent huang , mesos Date: Fri, 05 Aug 2016 11:45:10 -0000 Message-ID: <20160805114510.29918.75467@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?=@reviews.apache.org, =?utf-8?q?=3E?=@reviews.apache.org X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50812/ X-Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?= =?utf-8?q?=3E?= References: <20160804173047.14901.44503@reviews.apache.org> In-Reply-To: <20160804173047.14901.44503@reviews.apache.org> Reply-To: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cgaston=40mesosphere=2Ecom=3E?=@reviews.apache.org X-ReviewRequest-Repository: mesos --===============2225704611625879138== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/#review144916 ----------------------------------------------------------- include/mesos/mesos.proto (line 363) What do you think about calling this message `TCP` instead of `Socket`? - Gastón Kleiman On Aug. 4, 2016, 5:30 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50812/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 5:30 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Mahler, and Gastón Kleiman. > > > Bugs: MESOS-5987 > https://issues.apache.org/jira/browse/MESOS-5987 > > > Repository: mesos > > > Description > ------- > > Updated `HealthCheck` protobuf for HTTP and TCP health check. > > > Diffs > ----- > > include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 > include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 > > Diff: https://reviews.apache.org/r/50812/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============2225704611625879138==--