From reviews-return-42296-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 5 08:16:55 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DC0E195B3 for ; Fri, 5 Aug 2016 08:16:55 +0000 (UTC) Received: (qmail 62382 invoked by uid 500); 5 Aug 2016 08:16:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 62354 invoked by uid 500); 5 Aug 2016 08:16:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62340 invoked by uid 99); 5 Aug 2016 08:16:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 08:16:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C001D2BFB7B; Fri, 5 Aug 2016 08:16:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5616004479775626326==" MIME-Version: 1.0 Subject: Re: Review Request 50492: Switched replicated log to use PIDGroup. From: Jay Guo To: Joseph Wu Cc: Jay Guo , mesos Date: Fri, 05 Aug 2016 08:16:52 -0000 Message-ID: <20160805081652.29918.7903@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jay Guo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50492/ X-Sender: Jay Guo References: <20160728052327.11792.75406@reviews.apache.org> In-Reply-To: <20160728052327.11792.75406@reviews.apache.org> Reply-To: Jay Guo X-ReviewRequest-Repository: mesos --===============5616004479775626326== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/ ----------------------------------------------------------- (Updated Aug. 5, 2016, 8:16 a.m.) Review request for mesos and Joseph Wu. Summary (updated) ----------------- Switched replicated log to use PIDGroup. Bugs: MESOS-5828 https://issues.apache.org/jira/browse/MESOS-5828 Repository: mesos Description (updated) ------- The logic of log network was added to libprocess under name PIDGroup. This patch removed Network/NetworkProcess and switched replicated log to use PIDGroup instead. This is part of the code clean-up and modularizing PIDGroup abstraction alongside `MasterContender` and `MasterDetector`. Diffs (updated) ----- src/log/catchup.hpp 1e6d4c2d83cc3799084b186f8abd5a3a14c8d8ce src/log/catchup.cpp 94e1b00db2cd9d5a2368a979c1fd155bb6cac1f2 src/log/consensus.hpp 37337225d9a60cd3ef6015b122dddbefdeda9147 src/log/consensus.cpp 27f2c58c4c54cc3fe5b92873261096b6011ff15d src/log/coordinator.hpp 9fa4f1988c531a9765c9522a017b39fafb0a9cea src/log/coordinator.cpp ecf457ff266f447938ee6d2872a8ef3b6d50517e src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 src/log/log.cpp 0940f9288509409c1d593c27da48cfa2a50545c9 src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 src/log/recover.hpp 97793b6e1a26f92b4ae20b82e7da18d063776ce6 src/log/recover.cpp eaf3fd334f7b66f9ba05f3856ee885bab9af62f6 src/tests/log_tests.cpp 146a2dc8d54c06fa0a885a4760c45d5a10492128 Diff: https://reviews.apache.org/r/50492/diff/ Testing ------- see the end of review chain Thanks, Jay Guo --===============5616004479775626326==--