From reviews-return-42282-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 5 02:06:59 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 604C119C25 for ; Fri, 5 Aug 2016 02:06:59 +0000 (UTC) Received: (qmail 91822 invoked by uid 500); 5 Aug 2016 02:06:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91795 invoked by uid 500); 5 Aug 2016 02:06:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91781 invoked by uid 99); 5 Aug 2016 02:06:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 02:06:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D4C332BFD72; Fri, 5 Aug 2016 02:06:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1387707531817488654==" MIME-Version: 1.0 Subject: Re: Review Request 50421: Added code to detect proper zookeeper home directory. From: Mesos ReviewBot To: Joseph Wu , Alex Clemmer Cc: Mesos ReviewBot , Srinivas Brahmaroutu , mesos Date: Fri, 05 Aug 2016 02:06:56 -0000 Message-ID: <20160805020656.29918.14977@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50421/ X-Sender: Mesos ReviewBot References: <20160804204926.29918.68200@reviews.apache.org> In-Reply-To: <20160804204926.29918.68200@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============1387707531817488654== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/#review144861 ----------------------------------------------------------- Patch looks great! Reviews applied: [50421] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 4, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50421/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 8:49 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5905 > https://issues.apache.org/jira/browse/MESOS-5905 > > > Repository: mesos > > > Description > ------- > > Added code to detect proper zookeeper home directory. > > > Diffs > ----- > > src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 > > Diff: https://reviews.apache.org/r/50421/diff/ > > > Testing > ------- > > cmake && make > > test with autotools to make sure the tests run. > > > Thanks, > > Srinivas Brahmaroutu > > --===============1387707531817488654==--