From reviews-return-42129-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 3 12:54:52 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F4DE19508 for ; Wed, 3 Aug 2016 12:54:52 +0000 (UTC) Received: (qmail 1787 invoked by uid 500); 3 Aug 2016 12:54:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 1757 invoked by uid 500); 3 Aug 2016 12:54:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 1743 invoked by uid 99); 3 Aug 2016 12:54:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 12:54:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D54712BF302; Wed, 3 Aug 2016 12:54:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4680816852833005981==" MIME-Version: 1.0 Subject: Re: Review Request 50513: Added missing process IDs in libprocess. From: Alexander Rukletsov To: Alexander Rukletsov Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Wed, 03 Aug 2016 12:54:49 -0000 Message-ID: <20160803125449.14901.88549@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50513/ X-Sender: Alexander Rukletsov X-ReviewBoard-ShipIt: 1 References: <20160802134505.29918.29616@reviews.apache.org> In-Reply-To: <20160802134505.29918.29616@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============4680816852833005981== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50513/#review144607 ----------------------------------------------------------- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016, 1:45 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50513/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 1:45 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-5917 > https://issues.apache.org/jira/browse/MESOS-5917 > > > Repository: mesos > > > Description > ------- > > After this change, all libprocess actors should have a distinguishable > ID, making it possible to match the logging output or the output of > the "__process__" enpoint to the source actor. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc > 3rdparty/libprocess/include/process/protobuf.hpp 78ff40ed64c4313dd9daddcf96e1447ad015c734 > 3rdparty/libprocess/include/process/run.hpp d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f > 3rdparty/libprocess/src/authenticator.cpp 55e8558a5272cb0447ad9268ad9c7f27e2f30385 > 3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 > > Diff: https://reviews.apache.org/r/50513/diff/ > > > Testing > ------- > > `make check` in OS X and various linux distribution. > > I also looked at the output of the `__process__` endpoint. After this change, some of the unidentifiable processes have a nicer id now. The goal of this review chain is to give all processes there an identifiable ID. > > > Thanks, > > Gastón Kleiman > > --===============4680816852833005981==--