From reviews-return-42125-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 3 09:46:57 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A1FDC19CED for ; Wed, 3 Aug 2016 09:46:57 +0000 (UTC) Received: (qmail 46232 invoked by uid 500); 3 Aug 2016 09:46:57 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 46204 invoked by uid 500); 3 Aug 2016 09:46:57 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46185 invoked by uid 99); 3 Aug 2016 09:46:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 09:46:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 24EAC2A72A0; Wed, 3 Aug 2016 09:46:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1931478840488111086==" MIME-Version: 1.0 Subject: Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'. From: Mesos ReviewBot To: Jie Yu , Pierre Cheynier Cc: Mesos ReviewBot , Greg Mann , mesos Date: Wed, 03 Aug 2016 09:46:55 -0000 Message-ID: <20160803094655.29918.87453@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50609/ X-Sender: Mesos ReviewBot References: <20160802230454.14901.12530@reviews.apache.org> In-Reply-To: <20160802230454.14901.12530@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============1931478840488111086== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/#review144596 ----------------------------------------------------------- Patch looks great! Reviews applied: [50570, 50609] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 2, 2016, 11:04 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50609/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 11:04 p.m.) > > > Review request for mesos, Jie Yu and Pierre Cheynier. > > > Bugs: MESOS-5928 > https://issues.apache.org/jira/browse/MESOS-5928 > > > Repository: mesos > > > Description > ------- > > The recent removal of the agent's default `work_dir` > requires us to check for the presence of the `--version` > flag before we check for errors in flag loading; this > patch makes that change, and also moves the > corresponding code in the master for consistency. > > > Diffs > ----- > > src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 > src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 > > Diff: https://reviews.apache.org/r/50609/diff/ > > > Testing > ------- > > Ran the mesos agent and master binaries with and without the '--version' flag to verify correct behavior and return code. > > > Thanks, > > Greg Mann > > --===============1931478840488111086==--