From reviews-return-42077-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 2 21:30:49 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 218F4194B0 for ; Tue, 2 Aug 2016 21:30:49 +0000 (UTC) Received: (qmail 56819 invoked by uid 500); 2 Aug 2016 21:30:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56792 invoked by uid 500); 2 Aug 2016 21:30:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56770 invoked by uid 99); 2 Aug 2016 21:30:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 21:30:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AB7FE2BF1A1; Tue, 2 Aug 2016 21:30:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3929516836102343063==" MIME-Version: 1.0 Subject: Re: Review Request 50581: Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch. From: Gilbert Song To: Timothy Chen , Jie Yu , Artem Harutyunyan Cc: Gilbert Song , mesos Date: Tue, 02 Aug 2016 21:30:46 -0000 Message-ID: <20160802213046.14901.89475@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50581/ X-Sender: Gilbert Song References: <20160801235027.29917.95159@reviews.apache.org> In-Reply-To: <20160801235027.29917.95159@reviews.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============3929516836102343063== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50581/ ----------------------------------------------------------- (Updated Aug. 2, 2016, 2:30 p.m.) Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Repository: mesos Description ------- Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch. Diffs (updated) ----- src/slave/containerizer/mesos/launch.cpp 51f0c110ff0c414837fd69db81047979a0093388 Diff: https://reviews.apache.org/r/50581/diff/ Testing (updated) ------- make check sudo ./bin/mesos-tests.sh The sandbox log will look as the following: ``` Executing pre-exec command {"arguments":["mesos-containerizer","mount","--help=false","--operation=make-rslave","--path=\/"],"shell":false,"value":"\/home\/vagrant\/mesos\/build\/src\/mesos-containerizer"} Executing pre-exec command {"arguments":["mount","-n","--rbind","\/tmp\/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5\/slaves\/c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-S0\/frameworks\/c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-0000\/executors\/09e642aa-e545-44e9-8bca-18292b171cca\/runs\/7f494191-2518-4f37-836a-bcdee4b634f2","\/tmp\/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5\/provisioner\/containers\/7f494191-2518-4f37-836a-bcdee4b634f2\/backends\/copy\/rootfses\/43665fdd-2361-4a82-9f92-56ff21b428c9\/mnt\/mesos\/sandbox"],"shell":false,"value":"mount"} I0802 20:34:17.818397 29502 exec.cpp:161] Version: 1.1.0 I0802 20:34:17.826095 29561 exec.cpp:236] Executor registered on agent c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-S0 Received SUBSCRIBED event Subscribed executor on vagrant-ubuntu-trusty-64 Received LAUNCH event Starting task 09e642aa-e545-44e9-8bca-18292b171cca /home/vagrant/mesos/build/src/mesos-containerizer launch --command="{"shell":true,"value":"test -d \/mnt\/mesos\/sandbox"}" --help="false" --rootfs="/tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5/provisioner/containers/7f494191-2518-4f37-836a-bcdee4b634f2/backends/copy/rootfses/43665fdd-2361-4a82-9f92-56ff21b428c9" --unshare_namespace_mnt="false" --user="root" --working_directory="/mnt/mesos/sandbox" ``` Thanks, Gilbert Song --===============3929516836102343063==--