From reviews-return-42034-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 2 14:19:22 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E91719FD0 for ; Tue, 2 Aug 2016 14:19:22 +0000 (UTC) Received: (qmail 84067 invoked by uid 500); 2 Aug 2016 14:19:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 84039 invoked by uid 500); 2 Aug 2016 14:19:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83002 invoked by uid 99); 2 Aug 2016 14:19:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 14:19:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E8FA12BF217; Tue, 2 Aug 2016 14:19:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0984774911417816126==" MIME-Version: 1.0 Subject: Re: Review Request 50128: Added helper functions to 'Docker::Device'. From: Yubo Li To: Kevin Klues , Benjamin Mahler , Rajat Phull Cc: Mesos ReviewBot , mesos , Guangya Liu , Yubo Li Date: Tue, 02 Aug 2016 14:19:18 -0000 Message-ID: <20160802141918.14901.63792@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Yubo Li X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50128/ X-Sender: Yubo Li References: <20160729095220.11791.84308@reviews.apache.org> In-Reply-To: <20160729095220.11791.84308@reviews.apache.org> Reply-To: Yubo Li X-ReviewRequest-Repository: mesos --===============0984774911417816126== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ ----------------------------------------------------------- (Updated 八月 2, 2016, 2:19 p.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Changes ------- Changed commit order Summary (updated) ----------------- Added helper functions to 'Docker::Device'. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) ------- Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device' to handle data tranformation between 'Docker::Device' structure and string. Diffs (updated) ----- src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 Diff: https://reviews.apache.org/r/50128/diff/ Testing ------- make check Thanks, Yubo Li --===============0984774911417816126==--