From reviews-return-41952-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Mon Aug  1 23:08:59 2016
Return-Path: <reviews-return-41952-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 01E7219564
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Mon,  1 Aug 2016 23:08:59 +0000 (UTC)
Received: (qmail 57537 invoked by uid 500); 1 Aug 2016 23:08:58 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 57502 invoked by uid 500); 1 Aug 2016 23:08:58 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 57488 invoked by uid 99); 1 Aug 2016 23:08:58 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2016 23:08:58 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id AE51F2BE543;
	Mon,  1 Aug 2016 23:08:56 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2162287437729794910=="
MIME-Version: 1.0
Subject: Review Request 50676: Check for unsigned integers in
 Resources::count().
From: Anindya Sinha <anindya_sinha@apple.com>
To: Jiang Yan Xu <yan@jxu.me>
Cc: Anindya Sinha <anindya_sinha@apple.com>, mesos <reviews@mesos.apache.org>
Date: Mon, 01 Aug 2016 23:08:56 -0000
Message-ID: <20160801230856.29918.70237@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: Anindya Sinha <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/50676/
X-Sender: Anindya Sinha <noreply@reviews.apache.org>
Reply-To: Anindya Sinha <anindya_sinha@apple.com>
X-ReviewRequest-Repository: mesos

--===============2162287437729794910==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50676/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4892
    https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
-------

Resources::count() returns size_t, so the check needs to be for
unsigned integers.


Diffs
-----

  src/tests/resources_tests.cpp 06ccc0c6eb1ed248f1c1ceaedf5a0d85a422b49e 

Diff: https://reviews.apache.org/r/50676/diff/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


--===============2162287437729794910==--