| haosdent huang |
Re: Review Request 51083: Passed the pid of the container into `HealthChecker`. |
Wed, 24 Aug, 17:23 |
| haosdent huang |
Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace. |
Wed, 24 Aug, 17:23 |
| haosdent huang |
Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer. |
Wed, 24 Aug, 17:28 |
| haosdent huang |
Re: Review Request 51379: Entered the appropriate namespaces of the task during health check. |
Wed, 24 Aug, 18:03 |
| haosdent huang |
Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace. |
Wed, 24 Aug, 18:03 |
| haosdent huang |
Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`. |
Wed, 24 Aug, 18:04 |
| haosdent huang |
Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`. |
Wed, 24 Aug, 18:04 |
| Alexander Rukletsov |
Re: Review Request 51379: Entered the appropriate namespaces of the task during health check. |
Wed, 24 Aug, 20:25 |
| Zhitao Li |
Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP. |
Wed, 24 Aug, 20:32 |
| Jie Yu |
Review Request 51388: Replaced raw pointers in MesosContainerizer with Owned pointers. |
Wed, 24 Aug, 21:08 |
| Jie Yu |
Review Request 51389: A few style cleanups in MesosContainerizer. |
Wed, 24 Aug, 21:08 |
| Jie Yu |
Review Request 51390: Added a TODO about a bug in MesosContainerizer. |
Wed, 24 Aug, 21:08 |
| Jie Yu |
Review Request 51391: Fixed a bug related to logger in MesosContainerizer. |
Wed, 24 Aug, 21:09 |
| Gilbert Song |
Re: Review Request 51388: Replaced raw pointers in MesosContainerizer with Owned pointers. |
Wed, 24 Aug, 21:24 |
| Gilbert Song |
Re: Review Request 51389: A few style cleanups in MesosContainerizer. |
Wed, 24 Aug, 21:25 |
| Joseph Wu |
Re: Review Request 51210: Update mesos-executor name for Windows. |
Wed, 24 Aug, 21:27 |
| Joseph Wu |
Re: Review Request 51217: Added `os::execlp' in `stout` library. |
Wed, 24 Aug, 21:27 |
| Joseph Wu |
Re: Review Request 51213: Used `os::execlp` instead of `::execlp`. |
Wed, 24 Aug, 21:27 |
| Joseph Wu |
Re: Review Request 51233: Build a clean `Windows` environment for `mesos-executor`. |
Wed, 24 Aug, 21:28 |
| Gilbert Song |
Re: Review Request 51390: Added a TODO about a bug in MesosContainerizer. |
Wed, 24 Aug, 21:28 |
| Joseph Wu |
Re: Review Request 51234: Add `userenv` import library to `Windows` build. |
Wed, 24 Aug, 21:28 |
| Gilbert Song |
Review Request 51392: Supported provisioner listContainers() to be recursive. |
Wed, 24 Aug, 21:32 |
| Gilbert Song |
Review Request 51393: Added unit test for provisioner recursive listContainers(). |
Wed, 24 Aug, 21:32 |
| Benjamin Mahler |
Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master. |
Wed, 24 Aug, 21:33 |
| Benjamin Mahler |
Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master. |
Wed, 24 Aug, 21:33 |
| Mesos ReviewBot |
Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP. |
Wed, 24 Aug, 21:38 |
| Benjamin Mahler |
Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp. |
Wed, 24 Aug, 22:04 |
| Benjamin Mahler |
Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp. |
Wed, 24 Aug, 22:07 |
| Gilbert Song |
Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner. |
Wed, 24 Aug, 22:14 |
| Jiang Yan Xu |
Re: Review Request 51027: Track allocation candidates to bound allocator. |
Wed, 24 Aug, 22:41 |
| Mesos ReviewBot |
Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer. |
Wed, 24 Aug, 23:34 |
| Joseph Wu |
Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer. |
Wed, 24 Aug, 23:49 |
| Guangya Liu |
Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master. |
Wed, 24 Aug, 23:51 |
| Gilbert Song |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Thu, 25 Aug, 00:05 |
| Gilbert Song |
Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer. |
Thu, 25 Aug, 00:19 |
| Kevin Klues |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Thu, 25 Aug, 00:32 |
| Kevin Klues |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Thu, 25 Aug, 00:32 |
| Kevin Klues |
Re: Review Request 50128: Added helper functions to 'Docker::Device'. |
Thu, 25 Aug, 00:32 |
| Jie Yu |
Review Request 51400: Stopped passing messages in MesosContainerizer destroy methods. |
Thu, 25 Aug, 00:43 |
| Jie Yu |
Review Request 51401: Removed 'status' in the destroy chain in MesosContainerizer. |
Thu, 25 Aug, 00:43 |
| Kevin Klues |
Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware. |
Thu, 25 Aug, 00:47 |
| Gilbert Song |
Review Request 51402: Added nested container check in provisioner destroy. |
Thu, 25 Aug, 00:52 |
| Benjamin Mahler |
Review Request 51403: Added 'at' to LinkedHashMap. |
Thu, 25 Aug, 01:06 |
| Kevin Klues |
Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'. |
Thu, 25 Aug, 01:18 |
| Kevin Klues |
Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process. |
Thu, 25 Aug, 01:21 |
| Kevin Klues |
Review Request 51407: Updated mesos containerizer to checkpoint the container exit status. |
Thu, 25 Aug, 01:22 |
| Kevin Klues |
Review Request 51408: Updated test to account for new 'init' process semantics in a container. |
Thu, 25 Aug, 01:24 |
| Benjamin Mahler |
Review Request 51404: Updated the agent to reject multiple terminal status updates. |
Thu, 25 Aug, 01:29 |
| Mesos ReviewBot |
Re: Review Request 51393: Added unit test for provisioner recursive listContainers(). |
Thu, 25 Aug, 01:36 |
| Jie Yu |
Review Request 51409: Printed all the isolator cleanup errors during destory. |
Thu, 25 Aug, 01:40 |
| Vinod Kone |
Re: Review Request 51403: Added 'at' to LinkedHashMap. |
Thu, 25 Aug, 02:27 |
| Vinod Kone |
Re: Review Request 51404: Updated the agent to reject multiple terminal status updates. |
Thu, 25 Aug, 02:43 |
| Jiang Yan Xu |
Re: Review Request 45961: Support sharing of resources through reference counting of resources. |
Thu, 25 Aug, 03:22 |
| Mesos ReviewBot |
Re: Review Request 51402: Added nested container check in provisioner destroy. |
Thu, 25 Aug, 03:36 |
| Anindya Sinha |
Review Request 51412: Add offeredResources to Allocator::updateAllocation() API. |
Thu, 25 Aug, 04:13 |
| Anindya Sinha |
Re: Review Request 51412: Add offeredResources to Allocator::updateAllocation() API. |
Thu, 25 Aug, 04:13 |
| Anindya Sinha |
Re: Review Request 45960: Added interfaces to handle and track shareable resources. |
Thu, 25 Aug, 04:13 |
| Anindya Sinha |
Re: Review Request 45961: Support sharing of resources through reference counting of resources. |
Thu, 25 Aug, 04:14 |
| Anindya Sinha |
Re: Review Request 45962: Added a persistent volume test framework for shared volumes. |
Thu, 25 Aug, 04:15 |
| Anindya Sinha |
Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource. |
Thu, 25 Aug, 04:15 |
| Anindya Sinha |
Re: Review Request 45964: Add unit tests for sharing of resources. |
Thu, 25 Aug, 04:15 |
| Anindya Sinha |
Re: Review Request 45966: Offer shared resources to frameworks only if opted in. |
Thu, 25 Aug, 04:15 |
| Anindya Sinha |
Re: Review Request 45967: Added documentation for shareable resources. |
Thu, 25 Aug, 04:15 |
| Anindya Sinha |
Re: Review Request 49571: Added a benchmark test for allocations. |
Thu, 25 Aug, 04:15 |
| Guangya Liu |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Thu, 25 Aug, 05:06 |
| Jie Yu |
Review Request 51414: Fixed the using statements in MesosContainerizer. |
Thu, 25 Aug, 05:20 |
| Jie Yu |
Review Request 51415: A few consistency fix on indentation. |
Thu, 25 Aug, 05:20 |
| Jie Yu |
Review Request 51416: Fixed a TODO in the MesosContainerizer. |
Thu, 25 Aug, 05:20 |
| Jie Yu |
Review Request 51417: Removed a NOTE in MesosContainerizer that no longer applies. |
Thu, 25 Aug, 05:21 |
| Jie Yu |
Review Request 51418: Updated a few comments in MesosContainerizer. |
Thu, 25 Aug, 05:21 |
| Guangya Liu |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Thu, 25 Aug, 05:21 |
| Jie Yu |
Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer. |
Thu, 25 Aug, 05:23 |
| Mesos ReviewBot |
Re: Review Request 51408: Updated test to account for new 'init' process semantics in a container. |
Thu, 25 Aug, 05:23 |
| Srinivas Brahmaroutu |
Review Request 51410: Enabled meta discovery using appc labels. |
Thu, 25 Aug, 05:29 |
| Srinivas Brahmaroutu |
Review Request 51411: Added provisioner tests to provision using meta discovery. |
Thu, 25 Aug, 05:29 |
| Mesos ReviewBot |
Re: Review Request 49571: Added a benchmark test for allocations. |
Thu, 25 Aug, 07:11 |
| Gilbert Song |
Re: Review Request 51400: Stopped passing messages in MesosContainerizer destroy methods. |
Thu, 25 Aug, 08:05 |
| Gilbert Song |
Re: Review Request 51401: Removed 'status' in the destroy chain in MesosContainerizer. |
Thu, 25 Aug, 08:08 |
| Anindya Sinha |
Review Request 51419: Add offeredResources to Allocator::updateAllocation() API. |
Thu, 25 Aug, 08:11 |
| Anindya Sinha |
Re: Review Request 51419: Add offeredResources to Allocator::updateAllocation() API. |
Thu, 25 Aug, 08:11 |
| Anindya Sinha |
Re: Review Request 45961: Support sharing of resources through reference counting of resources. |
Thu, 25 Aug, 08:12 |
| Gilbert Song |
Review Request 51420: Added provisioner appc unit test for provisioning nested container. |
Thu, 25 Aug, 08:15 |
| Gilbert Song |
Review Request 51421: Added provisioner appc unit test for recovering nested container. |
Thu, 25 Aug, 08:15 |
| Gilbert Song |
Re: Review Request 51409: Printed all the isolator cleanup errors during destory. |
Thu, 25 Aug, 08:22 |
| Neil Conway |
Re: Review Request 50705: Changed master to allow partitioned slaves to reregister. |
Thu, 25 Aug, 08:23 |
| Gilbert Song |
Re: Review Request 51414: Fixed the using statements in MesosContainerizer. |
Thu, 25 Aug, 08:23 |
| Gilbert Song |
Re: Review Request 51415: A few consistency fix on indentation. |
Thu, 25 Aug, 08:24 |
| Gilbert Song |
Re: Review Request 51417: Removed a NOTE in MesosContainerizer that no longer applies. |
Thu, 25 Aug, 08:25 |
| Gilbert Song |
Re: Review Request 51418: Updated a few comments in MesosContainerizer. |
Thu, 25 Aug, 08:27 |
| Mesos ReviewBot |
Re: Review Request 51418: Updated a few comments in MesosContainerizer. |
Thu, 25 Aug, 09:02 |
| Neil Conway |
Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable". |
Thu, 25 Aug, 09:09 |
| Neil Conway |
Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable". |
Thu, 25 Aug, 09:09 |
| haosdent huang |
Re: Review Request 51379: Entered the appropriate namespaces of the task during health check. |
Thu, 25 Aug, 09:33 |
| Yubo Li |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Thu, 25 Aug, 09:35 |
| Yubo Li |
Review Request 51425: Added missed headers. |
Thu, 25 Aug, 09:37 |
| Yubo Li |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Thu, 25 Aug, 09:38 |
| Yubo Li |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Thu, 25 Aug, 09:40 |
| Mesos ReviewBot |
Re: Review Request 51411: Added provisioner tests to provision using meta discovery. |
Thu, 25 Aug, 10:06 |
| haosdent huang |
Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer. |
Thu, 25 Aug, 10:12 |
| haosdent huang |
Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer. |
Thu, 25 Aug, 10:19 |