| Jie Yu |
Re: Review Request 51171: Changed the provisioner recover/provision/destroy to be const methods. |
Mon, 22 Aug, 03:46 |
| Avinash sridharan |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 03:53 |
| Avinash sridharan |
Re: Review Request 51141: Simplified the mesos containerizer launch logic. |
Mon, 22 Aug, 03:56 |
| Jie Yu |
Re: Review Request 51172: Implemented the volume/image isolator. |
Mon, 22 Aug, 04:17 |
| Jie Yu |
Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer. |
Mon, 22 Aug, 04:25 |
| Jie Yu |
Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer. |
Mon, 22 Aug, 04:28 |
| Jie Yu |
Re: Review Request 51271: Fixed potential flakiness in ROOT_RecoverOrphanedPersistentVolume. |
Mon, 22 Aug, 04:28 |
| Jie Yu |
Re: Review Request 51161: Removed DestroyWhileProvisioningVolumeImage test. |
Mon, 22 Aug, 04:39 |
| Jie Yu |
Re: Review Request 51162: Kept a single provisioning future in MesosContainerizer. |
Mon, 22 Aug, 04:39 |
| Jie Yu |
Re: Review Request 51163: Refactored MesosContainerizer to prepare for nested container support. |
Mon, 22 Aug, 04:39 |
| Jie Yu |
Re: Review Request 51261: Fixed container ID related logging in MesosContainerizer. |
Mon, 22 Aug, 04:40 |
| Jie Yu |
Re: Review Request 51262: Changed the order so user specified env variables take precedence. |
Mon, 22 Aug, 04:40 |
| Jie Yu |
Re: Review Request 51263: Renamed containerizer::Termination to ContainerTermination. |
Mon, 22 Aug, 04:40 |
| Benjamin Hindman |
Review Request 51272: Refactored the agent 'launcher' flag to always have a value. |
Mon, 22 Aug, 04:53 |
| Gilbert Song |
Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer. |
Mon, 22 Aug, 04:54 |
| Benjamin Hindman |
Review Request 51273: Cleaned up a comment that was not accurate. |
Mon, 22 Aug, 04:54 |
| Benjamin Hindman |
Review Request 51274: Refactored Launcher helpers to be used in LinuxLauncher. |
Mon, 22 Aug, 04:54 |
| Benjamin Hindman |
Review Request 51275: Factored out a cgroups::isolate function. |
Mon, 22 Aug, 04:54 |
| Benjamin Hindman |
Review Request 51276: Added 'cgroups::traverse' helper. |
Mon, 22 Aug, 04:54 |
| Benjamin Hindman |
Review Request 51277: Added an 'ns::enter' helper. |
Mon, 22 Aug, 04:54 |
| Benjamin Hindman |
Review Request 51278: Refactored LinuxLauncher to be nested container aware. |
Mon, 22 Aug, 04:54 |
| Avinash sridharan |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 05:35 |
| Mesos ReviewBot |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 05:42 |
| Qian Zhang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 05:50 |
| Jie Yu |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 05:52 |
| Guangya Liu |
Re: Review Request 51172: Implemented the volume/image isolator. |
Mon, 22 Aug, 06:01 |
| Guangya Liu |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Mon, 22 Aug, 06:12 |
| Guangya Liu |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Mon, 22 Aug, 06:23 |
| Guangya Liu |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Mon, 22 Aug, 06:33 |
| Guangya Liu |
Re: Review Request 50128: Added helper functions to 'Docker::Device'. |
Mon, 22 Aug, 07:14 |
| Mesos ReviewBot |
Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware. |
Mon, 22 Aug, 07:17 |
| Tomasz Janiszewski |
Re: Review Request 51053: Update leveldb to 1.19. |
Mon, 22 Aug, 07:22 |
| Avinash sridharan |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 07:22 |
| Guangya Liu |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Mon, 22 Aug, 07:39 |
| Guangya Liu |
Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'. |
Mon, 22 Aug, 07:45 |
| Joerg Schad |
Review Request 51283: Fixed broken link in multiple disk documentation. |
Mon, 22 Aug, 08:28 |
| Qian Zhang |
Re: Review Request 51247: Fixed indentation in master/validation.cpp. |
Mon, 22 Aug, 08:39 |
| Yubo Li |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Mon, 22 Aug, 08:53 |
| Mesos ReviewBot |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 09:15 |
| Joerg Schad |
Re: Review Request 51283: Fixed broken link in multiple disk documentation. |
Mon, 22 Aug, 09:22 |
| Qian Zhang |
Re: Review Request 51248: Refactored task validations in master. |
Mon, 22 Aug, 09:33 |
| Guangya Liu |
Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer. |
Mon, 22 Aug, 09:33 |
| Benjamin Bannier |
Re: Review Request 51283: Fixed broken link in multiple disk documentation. |
Mon, 22 Aug, 09:33 |
| Yubo Li |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Mon, 22 Aug, 10:11 |
| Yubo Li |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Mon, 22 Aug, 10:11 |
| Yubo Li |
Re: Review Request 50128: Added helper functions to 'Docker::Device'. |
Mon, 22 Aug, 10:11 |
| Yubo Li |
Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'. |
Mon, 22 Aug, 10:12 |
| Yubo Li |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Mon, 22 Aug, 10:13 |
| Mesos ReviewBot |
Re: Review Request 51283: Fixed broken link in multiple disk documentation. |
Mon, 22 Aug, 10:55 |
| Benjamin Bannier |
Re: Review Request 51195: Refactored the test helper to use a single binary. |
Mon, 22 Aug, 12:56 |
| Benjamin Bannier |
Re: Review Request 51220: Moved setns test helper to the common test helper. |
Mon, 22 Aug, 12:56 |
| Benjamin Bannier |
Re: Review Request 51215: Moved memory test helper to the common test helper. |
Mon, 22 Aug, 12:56 |
| haosdent huang |
Review Request 51285: Fixed a compilation issue on clang. |
Mon, 22 Aug, 13:01 |
| haosdent huang |
Re: Review Request 51115: Replaced a static isolator cleanup function with lambda. |
Mon, 22 Aug, 13:04 |
| haosdent huang |
Re: Review Request 51053: Update leveldb to 1.19. |
Mon, 22 Aug, 13:05 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 13:22 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 13:22 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 13:22 |
| Qian Zhang |
Re: Review Request 51270: Added master validations for TaskGroup. |
Mon, 22 Aug, 13:39 |
| Guangya Liu |
Re: Review Request 51248: Refactored task validations in master. |
Mon, 22 Aug, 14:30 |
| Qian Zhang |
Re: Review Request 51096: Added the `mesos-port-mapper` binary. |
Mon, 22 Aug, 14:30 |
| Mesos ReviewBot |
Re: Review Request 51285: Fixed a compilation issue on clang. |
Mon, 22 Aug, 14:37 |
| Avinash sridharan |
Re: Review Request 51096: Added the `mesos-port-mapper` binary. |
Mon, 22 Aug, 15:03 |
| Avinash sridharan |
Re: Review Request 51096: Added the `mesos-port-mapper` binary. |
Mon, 22 Aug, 15:26 |
| Guangya Liu |
Re: Review Request 51248: Refactored task validations in master. |
Mon, 22 Aug, 15:27 |
| Guangya Liu |
Re: Review Request 51270: Added master validations for TaskGroup. |
Mon, 22 Aug, 15:33 |
| Avinash sridharan |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 15:50 |
| haosdent huang |
Review Request 51293: Fixed a typo in the comment of `Subsystem::watch`. |
Mon, 22 Aug, 16:11 |
| haosdent huang |
Review Request 51294: Removed unnecessary statements in `CgroupsIsolatorProcess::_watch`. |
Mon, 22 Aug, 16:11 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 16:12 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 16:12 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 16:45 |
| haosdent huang |
Re: Review Request 51091: Disallowed unknown cgroups isolator. |
Mon, 22 Aug, 16:46 |
| haosdent huang |
Re: Review Request 51031: Added non-recursive version of `cgroups::get`. |
Mon, 22 Aug, 16:47 |
| haosdent huang |
Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`. |
Mon, 22 Aug, 16:47 |
| haosdent huang |
Re: Review Request 49852: Implemented `NetClsSubsystem`. |
Mon, 22 Aug, 16:49 |
| haosdent huang |
Re: Review Request 49853: Implemented `PerfEventSubsystem`. |
Mon, 22 Aug, 16:49 |
| haosdent huang |
Re: Review Request 49855: Enabled cgroups unified isolator in isolation. |
Mon, 22 Aug, 16:49 |
| haosdent huang |
Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`. |
Mon, 22 Aug, 16:50 |
| haosdent huang |
Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess. |
Mon, 22 Aug, 16:50 |
| haosdent huang |
Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess. |
Mon, 22 Aug, 16:50 |
| haosdent huang |
Re: Review Request 50748: Removed CgroupsMemIsolatorProcess. |
Mon, 22 Aug, 16:50 |
| haosdent huang |
Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess. |
Mon, 22 Aug, 16:50 |
| haosdent huang |
Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess. |
Mon, 22 Aug, 16:50 |
| Joseph Wu |
Re: Review Request 51285: Fixed a compilation issue on clang. |
Mon, 22 Aug, 16:56 |
| haosdent huang |
Re: Review Request 51277: Added an 'ns::enter' helper. |
Mon, 22 Aug, 17:01 |
| haosdent huang |
Re: Review Request 51215: Moved memory test helper to the common test helper. |
Mon, 22 Aug, 17:13 |
| Gilbert Song |
Re: Review Request 51163: Refactored MesosContainerizer to prepare for nested container support. |
Mon, 22 Aug, 17:16 |
| Gilbert Song |
Re: Review Request 51261: Fixed container ID related logging in MesosContainerizer. |
Mon, 22 Aug, 17:20 |
| Gilbert Song |
Re: Review Request 51262: Changed the order so user specified env variables take precedence. |
Mon, 22 Aug, 17:27 |
| Mesos ReviewBot |
Re: Review Request 51097: Added a `PortMapper` class. |
Mon, 22 Aug, 17:32 |
| haosdent huang |
Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP. |
Mon, 22 Aug, 17:48 |
| haosdent huang |
Re: Review Request 51276: Added 'cgroups::traverse' helper. |
Mon, 22 Aug, 17:52 |
| Joseph Wu |
Review Request 51295: Updated `setsid` behavior in the logrotate container logger. |
Mon, 22 Aug, 17:53 |
| Joseph Wu |
Review Request 50770: CMake: Enable compilation of the logrotate module on Windows. |
Mon, 22 Aug, 17:53 |
| haosdent huang |
Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer. |
Mon, 22 Aug, 17:57 |
| Joseph Wu |
Re: Review Request 51257: Add external process container logger. |
Mon, 22 Aug, 18:03 |
| Vinod Kone |
Re: Review Request 51129: Renamed `JNIMesos` to `V1Mesos` for scheduler shim. |
Mon, 22 Aug, 18:04 |
| Vinod Kone |
Re: Review Request 51130: Exposed unversioned scheduler/executor protos in Mesos JAR. |
Mon, 22 Aug, 18:05 |
| haosdent huang |
Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP. |
Mon, 22 Aug, 18:12 |