| haosdent huang |
Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`. |
Sat, 20 Aug, 09:19 |
| haosdent huang |
Re: Review Request 49850: Implemented `CpuacctSubsystem`. |
Sat, 20 Aug, 09:19 |
| haosdent huang |
Re: Review Request 49854: Implemented `DevicesSubsystem`. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 49852: Implemented `NetClsSubsystem`. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 49855: Enabled cgroups unified isolator in isolation. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 50748: Removed CgroupsMemIsolatorProcess. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess. |
Sat, 20 Aug, 09:20 |
| haosdent huang |
Re: Review Request 49853: Implemented `PerfEventSubsystem`. |
Sat, 20 Aug, 09:21 |
| Mesos ReviewBot |
Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess. |
Sat, 20 Aug, 10:58 |
| Neil Conway |
Re: Review Request 51099: Fixed scalar resources output to print full significant digits. |
Sat, 20 Aug, 12:23 |
| Jie Yu |
Re: Review Request 49850: Implemented `CpuacctSubsystem`. |
Sat, 20 Aug, 16:34 |
| Will Rouesnel |
Review Request 51257: Add external process container logger. |
Sat, 20 Aug, 16:57 |
| Will Rouesnel |
Review Request 51258: Add documentation for the ExternalContainerLogger module. |
Sat, 20 Aug, 16:57 |
| Kevin Klues |
Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction. |
Sat, 20 Aug, 17:23 |
| Kevin Klues |
Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction. |
Sat, 20 Aug, 17:33 |
| Kevin Klues |
Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction. |
Sat, 20 Aug, 18:16 |
| Mesos ReviewBot |
Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction. |
Sat, 20 Aug, 19:43 |
| Kevin Klues |
Re: Review Request 51155: Added an agent flag for 'runtime_dir'. |
Sat, 20 Aug, 20:54 |
| Srinivas Brahmaroutu |
Re: Review Request 49689: Added Appc runtime isolator tests. |
Sat, 20 Aug, 21:05 |
| Jie Yu |
Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`. |
Sat, 20 Aug, 21:09 |
| Jie Yu |
Re: Review Request 49854: Implemented `DevicesSubsystem`. |
Sat, 20 Aug, 21:17 |
| Jie Yu |
Re: Review Request 49854: Implemented `DevicesSubsystem`. |
Sat, 20 Aug, 21:18 |
| Jie Yu |
Re: Review Request 51155: Added an agent flag for 'runtime_dir'. |
Sat, 20 Aug, 21:35 |
| Mesos ReviewBot |
Re: Review Request 49689: Added Appc runtime isolator tests. |
Sat, 20 Aug, 21:50 |
| Jie Yu |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Sat, 20 Aug, 21:56 |
| Jie Yu |
Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction. |
Sat, 20 Aug, 22:30 |
| Kevin Klues |
Re: Review Request 51155: Added an agent flag for 'runtime_dir'. |
Sun, 21 Aug, 00:47 |
| Kevin Klues |
Re: Review Request 51155: Added an agent flag for 'runtime_dir'. |
Sun, 21 Aug, 00:47 |
| Kevin Klues |
Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction. |
Sun, 21 Aug, 00:48 |
| Jie Yu |
Review Request 51261: Fixed container ID related logging in MesosContainerizer. |
Sun, 21 Aug, 00:49 |
| Jie Yu |
Review Request 51262: Changed the order so user specified env variables take precedence. |
Sun, 21 Aug, 00:49 |
| Jie Yu |
Review Request 51263: Renamed containerizer::Termination to ContainerTermination. |
Sun, 21 Aug, 00:50 |
| Mesos ReviewBot |
Re: Review Request 51263: Renamed containerizer::Termination to ContainerTermination. |
Sun, 21 Aug, 01:41 |
| haosdent huang |
Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`. |
Sun, 21 Aug, 05:52 |
| Avinash sridharan |
Re: Review Request 51097: Added a `PortMapper` class. |
Sun, 21 Aug, 06:01 |
| Mesos ReviewBot |
Re: Review Request 51097: Added a `PortMapper` class. |
Sun, 21 Aug, 07:37 |
| Guangya Liu |
Re: Review Request 51172: Implemented the volume/image isolator. |
Sun, 21 Aug, 07:58 |
| haosdent huang |
Re: Review Request 51091: Disallowed unknown cgroups isolator. |
Sun, 21 Aug, 09:10 |
| haosdent huang |
Re: Review Request 51031: Added non-recursive version of `cgroups::get`. |
Sun, 21 Aug, 09:10 |
| haosdent huang |
Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`. |
Sun, 21 Aug, 09:10 |
| haosdent huang |
Review Request 51265: Allowed clean up unknown containers. |
Sun, 21 Aug, 09:11 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Sun, 21 Aug, 09:13 |
| haosdent huang |
Re: Review Request 49852: Implemented `NetClsSubsystem`. |
Sun, 21 Aug, 09:13 |
| haosdent huang |
Re: Review Request 51265: Allowed clean up unknown containers. |
Sun, 21 Aug, 09:29 |
| haosdent huang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Sun, 21 Aug, 09:29 |
| haosdent huang |
Re: Review Request 49852: Implemented `NetClsSubsystem`. |
Sun, 21 Aug, 09:29 |
| haosdent huang |
Re: Review Request 49853: Implemented `PerfEventSubsystem`. |
Sun, 21 Aug, 09:29 |
| haosdent huang |
Re: Review Request 49855: Enabled cgroups unified isolator in isolation. |
Sun, 21 Aug, 09:29 |
| haosdent huang |
Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`. |
Sun, 21 Aug, 09:29 |
| haosdent huang |
Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess. |
Sun, 21 Aug, 09:30 |
| haosdent huang |
Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess. |
Sun, 21 Aug, 09:30 |
| haosdent huang |
Re: Review Request 50748: Removed CgroupsMemIsolatorProcess. |
Sun, 21 Aug, 09:30 |
| haosdent huang |
Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess. |
Sun, 21 Aug, 09:30 |
| haosdent huang |
Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess. |
Sun, 21 Aug, 09:30 |
| haosdent huang |
Re: Review Request 49854: Implemented `DevicesSubsystem`. |
Sun, 21 Aug, 09:31 |
| Mesos ReviewBot |
Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess. |
Sun, 21 Aug, 10:57 |
| Guangya Liu |
Re: Review Request 50523: Updated docker recovery to account for GPU resources. |
Sun, 21 Aug, 15:00 |
| Guangya Liu |
Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect. |
Sun, 21 Aug, 15:15 |
| Mesos ReviewBot |
Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect. |
Sun, 21 Aug, 15:49 |
| Jie Yu |
Re: Review Request 51265: Allowed clean up unknown containers. |
Sun, 21 Aug, 17:43 |
| Gilbert Song |
Re: Review Request 51171: Supported image provisioner singleton methods for global pointer. |
Sun, 21 Aug, 17:54 |
| haosdent huang |
Review Request 51266: Unshared the mount namespace when launching mesos-containerizer. |
Sun, 21 Aug, 18:21 |
| haosdent huang |
Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way. |
Sun, 21 Aug, 18:21 |
| haosdent huang |
Review Request 51267: Defined mesos-health-check-helper in cmake configuration. |
Sun, 21 Aug, 18:21 |
| haosdent huang |
Review Request 51268: Added mesos-health-check-helper. |
Sun, 21 Aug, 18:22 |
| haosdent huang |
Review Request 51269: Switched to use mesos-health-check-helper perform health check. |
Sun, 21 Aug, 18:22 |
| haosdent huang |
Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`. |
Sun, 21 Aug, 18:22 |
| haosdent huang |
Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`. |
Sun, 21 Aug, 18:23 |
| haosdent huang |
Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer. |
Sun, 21 Aug, 18:42 |
| haosdent huang |
Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way. |
Sun, 21 Aug, 18:42 |
| haosdent huang |
Re: Review Request 51267: Defined mesos-health-check-helper in cmake configuration. |
Sun, 21 Aug, 18:42 |
| haosdent huang |
Re: Review Request 51268: Added mesos-health-check-helper. |
Sun, 21 Aug, 18:43 |
| haosdent huang |
Re: Review Request 51269: Switched to use mesos-health-check-helper perform health check. |
Sun, 21 Aug, 18:43 |
| haosdent huang |
Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`. |
Sun, 21 Aug, 18:43 |
| haosdent huang |
Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`. |
Sun, 21 Aug, 18:43 |
| Gilbert Song |
Re: Review Request 51161: Removed DestroyWhileProvisioningVolumeImage test. |
Sun, 21 Aug, 21:45 |
| Gilbert Song |
Re: Review Request 51162: Kept a single provisioning future in MesosContainerizer. |
Sun, 21 Aug, 21:47 |
| Vinod Kone |
Review Request 51247: Fixed indentation in master/validation.cpp. |
Sun, 21 Aug, 23:22 |
| Vinod Kone |
Review Request 51248: Refactored task validations in master. |
Sun, 21 Aug, 23:28 |
| Vinod Kone |
Review Request 51270: Added master validations for TaskGroup. |
Sun, 21 Aug, 23:29 |
| Vinod Kone |
Re: Review Request 51247: Fixed indentation in master/validation.cpp. |
Sun, 21 Aug, 23:30 |
| Mesos ReviewBot |
Re: Review Request 51270: Added master validations for TaskGroup. |
Mon, 22 Aug, 00:20 |
| Gilbert Song |
Re: Review Request 51170: Removed 'recover()' in docker runtime isolator. |
Mon, 22 Aug, 01:36 |
| Gilbert Song |
Re: Review Request 51170: Removed 'recover()' in docker runtime isolator. |
Mon, 22 Aug, 01:36 |
| Gilbert Song |
Re: Review Request 51141: Simplified the mesos containerizer launch logic. |
Mon, 22 Aug, 02:10 |
| Gilbert Song |
Re: Review Request 51171: Changed the provisioner recover/provision/destroy to be const methods. |
Mon, 22 Aug, 02:11 |
| Gilbert Song |
Re: Review Request 51172: Implemented the volume/image isolator. |
Mon, 22 Aug, 02:13 |
| Gilbert Song |
Re: Review Request 51172: Implemented the volume/image isolator. |
Mon, 22 Aug, 02:14 |
| Gilbert Song |
Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer. |
Mon, 22 Aug, 02:14 |
| Gilbert Song |
Review Request 51271: Fixed potential flakiness in ROOT_RecoverOrphanedPersistentVolume. |
Mon, 22 Aug, 02:15 |
| Vinod Kone |
Re: Review Request 51053: Update leveldb to 1.19. |
Mon, 22 Aug, 02:29 |
| Mesos ReviewBot |
Re: Review Request 51271: Fixed potential flakiness in ROOT_RecoverOrphanedPersistentVolume. |
Mon, 22 Aug, 02:34 |
| Qian Zhang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 02:52 |
| Qian Zhang |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 03:04 |
| Jie Yu |
Re: Review Request 49851: Implemented `MemorySubsystem`. |
Mon, 22 Aug, 03:09 |