mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.
Date Fri, 26 Aug 2016 14:12:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51069/
-----------------------------------------------------------

(Updated Aug. 26, 2016, 2:12 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert Song,
Jie Yu, and Timothy Chen.


Changes
-------

Address @alexr's comments.


Repository: mesos


Description (updated)
-------

* Removed blocking `Future::await` call.
* Adjust the level of some logs.
* Adjust style.
* Change the interface of health check handlers to
  `Future<Nothing>` to make errors handling more easier.


Diffs (updated)
-----

  src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
  src/health-check/health_checker.cpp 5bdbd2ab45feecfab494bcacfbcc92c396f4f723 

Diff: https://reviews.apache.org/r/51069/diff/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message