mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 49360: Supported TCP in health check.
Date Fri, 26 Aug 2016 12:37:35 GMT


> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote:
> > src/health-check/health_checker.cpp, line 452
> > <https://reviews.apache.org/r/49360/diff/14/?file=1485773#file1485773line452>
> >
> >     Will it work on all supported systems?
> 
> haosdent huang wrote:
>     Windows also have bash now but require external installation. But bash is a temporary
solution. We are plan to implement a tiny program which suppport TCP half open and replace
bash with it.

No, it won't. It's `bash`-only extension, may not be available on some machines. Officially,
Mesos does not depend on `bash`, we are not going to introduce this dependency : ). We will
be replacing bash with a tiny connection checker ASAP (read in the same release).


> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote:
> > src/health-check/health_checker.cpp, line 518
> > <https://reviews.apache.org/r/49360/diff/14/?file=1485773#file1485773line518>
> >
> >     `bash` appears in 3 places and may be extracted to constant.

Good comment. As I've mentioned before, the `bash`-approach is not here to stay. Hence not
important *here*.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49360/#review146777
-----------------------------------------------------------


On Aug. 25, 2016, 1:25 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49360/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 1:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert
Song, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3567
>     https://issues.apache.org/jira/browse/MESOS-3567
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported TCP in health check.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
>   src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 
> 
> Diff: https://reviews.apache.org/r/49360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message