mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 51374: Change registry update order on removal, mark-unreachable.
Date Thu, 25 Aug 2016 21:00:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51374/
-----------------------------------------------------------

(Updated Aug. 25, 2016, 9 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fix thinko in commit message.


Summary (updated)
-----------------

Change registry update order on removal, mark-unreachable.


Bugs: MESOS-4049 and MESOS-6090
    https://issues.apache.org/jira/browse/MESOS-4049
    https://issues.apache.org/jira/browse/MESOS-6090


Repository: mesos


Description (updated)
-------

This commit changes the master so that we always update the registry
for an important change (e.g., removing an agent or marking an agent
unreachable), before updating the important parts of the master's
in-memory state (e.g., the in-memory list of registered agents).
Previously, the registry was updated first for registration and
reregistration, but second for removal and marking unreachable.
Updating the registry first is simpler, and also avoids possibly
leaking inaccurate information (e.g., via HTTP endpoints) if the
registry operation fails.


Diffs (updated)
-----

  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 789fb9760a5ea60ce3b7b08f17e36cec69349c60 
  src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
  src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 
  src/tests/slave_tests.cpp 84ee37cae97004914b3f0a060dc854e531737dce 

Diff: https://reviews.apache.org/r/51374/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message