mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 51124: Support more layers through symlink for overlay backend.
Date Thu, 25 Aug 2016 16:13:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51124/
-----------------------------------------------------------

(Updated Aug. 25, 2016, 4:13 p.m.)


Review request for mesos, Xiaojian Huang, Gilbert Song, and Jie Yu.


Changes
-------

- Clean up symlink more aggressively;
- Add test for temp dir and symlink;
- Pass backendDir to `Backend::destroy` and `OverlayBackendProcess::destroy`.


Bugs: MESOS-6000
    https://issues.apache.org/jira/browse/MESOS-6000


Repository: mesos


Description
-------

Support more layers through symlink for overlay backend.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/backend.hpp 93819c887f2f801f06aae7020084b56cc81ce818

  src/slave/containerizer/mesos/provisioner/backends/aufs.hpp a5ac13bc17b8f291472b622ebfdd0cd1dd072273

  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 4c5cdb660dea205aea29d217ba80d845d1108fdf

  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 19d44c6a9a2cd5f8de79f33c76e9d79900ab003f

  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 62ccaec1a5cfb466e929f4db7bf7e5376f2a0c2d

  src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5bd6a5279d8dd6d088afcd58e4839bf6087ccd1e

  src/slave/containerizer/mesos/provisioner/backends/copy.cpp e57bb3d2fb4e67e9caae416824a6a748db1460a1

  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 387f28a331813c75a509b4a31dbbdc764080b8c1

  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e20cd48463a78ecd8a652a4d5ac923dc02cca4d9

  src/slave/containerizer/mesos/provisioner/provisioner.cpp ad19feccf08112f94d6514a134963c54ca541e88

  src/tests/containerizer/provisioner_backend_tests.cpp 7c9a7cd5c733f74e10316fc1234115e6820cc2cb


Diff: https://reviews.apache.org/r/51124/diff/


Testing
-------

1. Make sure `OverlayBackendTest.*` passes;
2. Use mesos-execute to provision a container using overlay backend. Observed following log
lines:

```
I0816 01:04:27.823420 46584 overlay.cpp:167] Created tempLink at '/var/lib/mesos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/links'
to '/tmp/NcmRZt'
I0816 01:04:27.824834 46584 overlay.cpp:191] Provisioning image rootfs with overlayfs: 'lowerdir=/tmp/NcmRZt/42:/tmp/NcmRZt/41:/tmp/NcmRZt/40:/tmp/NcmRZt/39:/tmp/NcmRZt/38:/tmp/NcmRZt/37:/tmp/NcmRZt/36:/tmp/NcmRZt/35:/tmp/NcmRZt/34:/tmp/NcmRZt/33:/tmp/NcmRZt/32:/tmp/NcmRZt/31:/tmp/NcmRZt/30:/tmp/NcmRZt/29:/tmp/NcmRZt/28:/tmp/NcmRZt/27:/tmp/NcmRZt/26:/tmp/NcmRZt/25:/tmp/NcmRZt/24:/tmp/NcmRZt/23:/tmp/NcmRZt/22:/tmp/NcmRZt/21:/tmp/NcmRZt/20:/tmp/NcmRZt/19:/tmp/NcmRZt/18:/tmp/NcmRZt/17:/tmp/NcmRZt/16:/tmp/NcmRZt/15:/tmp/NcmRZt/14:/tmp/NcmRZt/13:/tmp/NcmRZt/12:/tmp/NcmRZt/11:/tmp/NcmRZt/10:/tmp/NcmRZt/9:/tmp/NcmRZt/8:/tmp/NcmRZt/7:/tmp/NcmRZt/6:/tmp/NcmRZt/5:/tmp/NcmRZt/4:/tmp/NcmRZt/3:/tmp/NcmRZt/2:/tmp/NcmRZt/1:/tmp/NcmRZt/0,upperdir=/var/lib/mesos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/scratch/25d9b6e4-fd0e-401e-bb9e-754dbaec4f55/upperdir,workdir=/var/lib/mesos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/scratch/25d
 9b6e4-fd0e-401e-bb9e-754dbaec4f55/workdir'
...
(after executor exited)
I0816 01:04:34.859851 46584 overlay.cpp:281] Removed temporary directory '/tmp/NcmRZt' pointed
by '/var/lib/mesos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/links'
```


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message