mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50707: Added test for agent removal behavior.
Date Thu, 25 Aug 2016 14:30:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50707/
-----------------------------------------------------------

(Updated Aug. 25, 2016, 2:30 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Tweak comment.


Bugs: MESOS-4049
    https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
-------

This test tries to simulate a race between marking an agent unhealthy
and receiving an `UnregisterSlaveMessage` for that agent.

Unfortunately, this test is a little fragile (we need to manually
dispatch an event to the master process to simulate the action that
would be taken by the slave observer).


Diffs (updated)
-----

  src/tests/slave_tests.cpp 84ee37cae97004914b3f0a060dc854e531737dce 

Diff: https://reviews.apache.org/r/50707/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message