mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".
Date Thu, 25 Aug 2016 09:09:26 GMT


> On Aug. 22, 2016, 7:43 p.m., Vinod Kone wrote:
> > src/master/metrics.hpp, lines 183-184
> > <https://reviews.apache.org/r/50702/diff/2/?file=1471749#file1471749line183>
> >
> >     can you add this to the CHANGELOG for 1.1 under "Deprecations" section?

Done. Note that I haven't yet attempted to update the docs for these changes in general, which
will require lots more updates.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50702/#review146419
-----------------------------------------------------------


On Aug. 25, 2016, 9:09 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50702/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 9:09 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master will shortly be changed to no longer shutdown unhealthy
> agents, so the previous metric name is no longer accurate. The old
> metric names have been kept for backwards compatibility, but they
> are no longer updated (i.e., they will always be set to zero).
> 
> 
> Diffs
> -----
> 
>   CHANGELOG ffeaf100c5caf2cefdd07751551ba06b0c09fed5 
>   docs/monitoring.md e19ecd0ad23538da288577da0237d067459aa7ba 
>   src/master/master.cpp 789fb9760a5ea60ce3b7b08f17e36cec69349c60 
>   src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
>   src/master/metrics.cpp 88a752dc2b4b73ccb919e99478b9ea2bd83842a0 
>   src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
>   src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 
> 
> Diff: https://reviews.apache.org/r/50702/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message