mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.
Date Thu, 25 Aug 2016 00:47:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51278/#review146740
-----------------------------------------------------------




src/slave/containerizer/mesos/linux_launcher.cpp (line 132)
<https://reviews.apache.org/r/51278/#comment213395>

    There's something wrong with this logic. The top level directory of the cgroup begins
with `mesos`, not the first container ID. We either need to strip this here or at a level
above.


- Kevin Klues


On Aug. 22, 2016, 4:54 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51278/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 4:54 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note, this doesn't yet include the use of 'ns::enter' for creating
> nested containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.hpp 8fbe1e9742df85b0fc6de46ac81a0c064c845a63

>   src/slave/containerizer/mesos/linux_launcher.cpp 7377316776646e3d660086da3c0d5b494ce8ace4

> 
> Diff: https://reviews.apache.org/r/51278/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message