mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 51371: Fixed a fragile test case.
Date Wed, 24 Aug 2016 15:47:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51371/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-4049
    https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
-------

The goal of this test is to check this interleaving:

  task launch: block on authorization
  slave disconnects: removed by master
  auth succeeds: we expect the task launch to fail

However, the test neglected to ensure that slave removal was completed
before allowing authorization to succeed.


Diffs
-----

  src/tests/master_authorization_tests.cpp 92bd2a9463f861e4b479f76927dd01324765a411 

Diff: https://reviews.apache.org/r/51371/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message