mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".
Date Wed, 24 Aug 2016 15:36:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 24, 2016, 3:36 p.m.)

Review request for mesos and Vinod Kone.


Address review comments.

Bugs: MESOS-4049

Repository: mesos


The master will shortly be changed to no longer shutdown unhealthy
agents, so the previous metric name is no longer accurate. The old
metric names have been kept for backwards compatibility, but they
are no longer updated (i.e., they will always be set to zero).

Diffs (updated)

  CHANGELOG ffeaf100c5caf2cefdd07751551ba06b0c09fed5 
  docs/ e19ecd0ad23538da288577da0237d067459aa7ba 
  src/master/master.cpp 910293ad16a4eab5ac1e0815406f42dda90c4896 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 88a752dc2b4b73ccb919e99478b9ea2bd83842a0 
  src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
  src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 



make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message