mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50701: Added registrar operations for marking agents (un-)reachable.
Date Wed, 24 Aug 2016 15:30:44 GMT


> On Aug. 22, 2016, 7:39 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 1951
> > <https://reviews.apache.org/r/50701/diff/2/?file=1471692#file1471692line1951>
> >
> >     since reachable agents can be marked as reachable again, why not allow unreachable
agents to be marked as unreachable again?

I felt like this was a useful sanity check: this shouldn't be possible given the current coding
(as far as I know), so it seems better to report an error in this situation.


> On Aug. 22, 2016, 7:39 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 1976
> > <https://reviews.apache.org/r/50701/diff/2/?file=1471692#file1471692line1976>
> >
> >     looks like only 'id' is ever used.
> >     
> >     s/SlaveInfo info/SlaveID id/
> >     
> >     if you want to keep SlaveInfo for consistency with other operations, that's
fine as well.

I'm inclined to keep using `SlaveInfo` for consistency with the other operations.


> On Aug. 22, 2016, 7:39 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 2000
> > <https://reviews.apache.org/r/50701/diff/2/?file=1471692#file1471692line2000>
> >
> >     s/:/;/ ?

I think a colon is fine here.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50701/#review146394
-----------------------------------------------------------


On Aug. 12, 2016, 12:22 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50701/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added registrar operations for marking agents (un-)reachable.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
>   src/tests/registrar_tests.cpp 9a71d8fd0c8d8e662a5e364015d144396a0b1a4c 
> 
> Diff: https://reviews.apache.org/r/50701/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message