mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51275: Factored out a cgroups::isolate function.
Date Wed, 24 Aug 2016 09:46:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51275/#review146629
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/cgroups.hpp (line 323)
<https://reviews.apache.org/r/51275/#comment213186>

    s/Some/Nothing/


- Qian Zhang


On Aug. 22, 2016, 12:54 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51275/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 12:54 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleans up code in LinuxLauncher. Adds a useful function for others to
> use other places if necessary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 047d3ea596660e704447c0f0c7b914a43c4a2187 
>   src/linux/cgroups.cpp f3232c009d04bb82701c0407b12abf999ab60a73 
>   src/slave/containerizer/mesos/linux_launcher.cpp 7377316776646e3d660086da3c0d5b494ce8ace4

> 
> Diff: https://reviews.apache.org/r/51275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message