mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49617: Add benchmark for failover of many frameworks.
Date Wed, 24 Aug 2016 09:12:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review146625
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 4030)
<https://reviews.apache.org/r/49617/#comment213179>

    How about adding `ports` resources to the allocation here.
    
    ```
    // Each agent has a portion of it's resources allocated to a single
    // framework. We round-robin through the frameworks when allocating.
    Resources allocation = Resources::parse("cpus:16;mem:1024;disk:1024").get();
    
    Try<::mesos::Value::Ranges> ranges = fragment(createRange(31000, 32000), 16);
    ASSERT_SOME(ranges);
    ASSERT_EQ(16, ranges->range_size());
    
    allocation += createPorts(ranges.get());
    ```



src/tests/hierarchical_allocator_tests.cpp (line 4035)
<https://reviews.apache.org/r/49617/#comment213180>

    Add `ports` resource here for each agent.



src/tests/hierarchical_allocator_tests.cpp (lines 4091 - 4099)
<https://reviews.apache.org/r/49617/#comment213177>

    Can we make sure all of the `allocations` are available when `recoverResources`? Do we
need a `Clock::settle();` after all `suppressOffers` finshed in line 4090?


- Guangya Liu


On 八月 17, 2016, 2:26 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> -----------------------------------------------------------
> 
> (Updated 八月 17, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
>     https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered resources
>   and suppressed in batches.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/49617/diff/
> 
> 
> Testing
> -------
> 
> MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.FrameworkFailover*" make check
> 
> Sample Output:
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23
> Using 10000 agents and 6000 frameworks
> Added 6000 frameworks in 113410us
> Added 10000 agents in 6.83980663333333mins
> allocator settled after  3.28683733333333mins
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23
(609255 ms)[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
> Using 20000 agents and 1 frameworks
> Added 1 frameworks in 190us
> Added 20000 agents in 4.752954secs
> allocator settled after  7us
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
(6332 ms)
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message