-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50836/#review146622
-----------------------------------------------------------
Patch looks great!
Reviews applied: [50836]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Aug. 23, 2016, 10:19 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50836/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We do not want people call add/subtract resoure object directly,
> so should make those methods as private.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp bdbe8ea03a50cd1361640bde13a2342909723fc5
> include/mesos/v1/resources.hpp c05cb634c7a5add78da00cb84fc75d3472a341bc
> src/common/resources.cpp 96b4c39507bdb9b88aca5c2178b88057a5fc1881
> src/v1/resources.cpp 3cc7580d5567370530c53759713be05c369bf298
>
> Diff: https://reviews.apache.org/r/50836/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> ```
> ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
> ./bin/mesos-tests.sh --gtest_filter="SharedResourcesTest.*"
> ```
>
>
> Thanks,
>
> Guangya Liu
>
>
|