mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51321: Added a test to ensure the master handles launching task groups.
Date Wed, 24 Aug 2016 01:17:54 GMT


> On 八月 24, 2016, 12:41 a.m., Vinod Kone wrote:
> > src/tests/scheduler_tests.cpp, line 548
> > <https://reviews.apache.org/r/51321/diff/1/?file=1481653#file1481653line548>
> >
> >     ASSERT_EQ(runTaskGroupMessage->task_group(), 2);

I think that we are always putting the `expected value` as the first parameter, so would expect
the following:

```
ASSERT_EQ(2, runTaskGroupMessage->task_group().tasks().size());
```


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51321/#review146597
-----------------------------------------------------------


On 八月 23, 2016, 5:11 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51321/
> -----------------------------------------------------------
> 
> (Updated 八月 23, 2016, 5:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6045
>     https://issues.apache.org/jira/browse/MESOS-6045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For now this test ensures the message is sent to the agent
> in the successful launch path. More tests will be added to
> test the all-or-nothing paths (killed, invalid, unauthorized).
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/51321/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message