mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajat Phull <rph...@nvidia.com>
Subject Re: Review Request 50523: Updated docker recovery to account for GPU resources.
Date Wed, 24 Aug 2016 00:57:35 GMT


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1021
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1021>
> >
> >     I'd prefer
> >     
> >     ```
> >     if (!deviceInspect.isSome()) {
> >       return Nothing();
> >     }
> >     
> >     other logic here...
> >     
> >     ```

The method parseInspectDevices and deviceInspect.isSome will be dropped as the other commit
gets squashed into this one.


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1065
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1065>
> >
> >     kill this

The method parseInspectDevices will be dropped as the other commit gets squashed into this
commit.


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1065-1099
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1065>
> >
> >     two spaces is enough

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1079
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1079>
> >
> >     s/Option<set < string>>/Option<set<string>>

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1081-1082
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1081>
> >
> >     new line here

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1081-1082
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1081>
> >
> >     new line

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1082
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1082>
> >
> >     I'd prefer
> >     
> >     ```
> >     if (!deviceJson.isSome()) {
> >       return None();
> >     }
> >     
> >     other logic...
> >     ```

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1084
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1084>
> >
> >     s/std::vector/vector
> >     
> >     s/.get()./->

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1085
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1085>
> >
> >     I'd prefer
> >     
> >     ```
> >     if (values.size() == 0) {
> >       return None();
> >     }
> >     ```

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1088-1089
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1088>
> >
> >     ```
> >     Result<JSON::String> devicePath =
> >       value.as<JSON::Object>().find<JSON::String>("PathOnHost");
> >     ```

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1089-1090
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1089>
> >
> >     new line

This method will be dropped as the commits are squashed


> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1092
> > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1092>
> >
> >     s/.get()./->

This method will be dropped as the commits are squashed


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/#review146261
-----------------------------------------------------------


On Aug. 24, 2016, 12:56 a.m., Rajat Phull wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50523/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 12:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docker recovery to account for GPU resources.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d 
>   src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 
>   src/tests/containerizer/docker_containerizer_tests.cpp 42d4364b6fcbc94c7852721511001c103cb5a90d

> 
> Diff: https://reviews.apache.org/r/50523/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" make
-j check
> 
> 
> Thanks,
> 
> Rajat Phull
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message