-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/
-----------------------------------------------------------
(Updated Aug. 24, 2016, 12:56 a.m.)
Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama Ditya.
Changes
-------
Addressed first set of comments with the exception on one comment on about changing nvidiaGpuAllocator.get().allocate(gpus.get()).
Investigating it further before making that change.
Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795
Repository: mesos
Description
-------
Updated docker recovery to account for GPU resources.
Diffs (updated)
-----
src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
src/tests/containerizer/docker_containerizer_tests.cpp 42d4364b6fcbc94c7852721511001c103cb5a90d
Diff: https://reviews.apache.org/r/50523/diff/
Testing (updated)
-------
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" make -j
check
Thanks,
Rajat Phull
|