mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.
Date Wed, 24 Aug 2016 00:38:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51320/#review146585
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp (line 3257)
<https://reviews.apache.org/r/51320/#comment213086>

    do you want to add a "messages_launch_task_groups" metric?



src/master/master.cpp (line 3916)
<https://reviews.apache.org/r/51320/#comment213110>

    any tasks



src/master/master.cpp (line 3933)
<https://reviews.apache.org/r/51320/#comment213111>

    move this to next line.



src/master/master.cpp (lines 3937 - 3939)
<https://reviews.apache.org/r/51320/#comment213112>

    this could be `else {` ?



src/master/master.cpp (lines 4002 - 4004)
<https://reviews.apache.org/r/51320/#comment213113>

    why is this comment here? move this to #3975 may be?



src/master/master.cpp (line 4014)
<https://reviews.apache.org/r/51320/#comment213120>

    can you add a TODO here to do this killing in `killTask()` instead of here?



src/master/master.cpp (line 4026)
<https://reviews.apache.org/r/51320/#comment213119>

    s/executor/agent/



src/master/master.cpp (line 4041)
<https://reviews.apache.org/r/51320/#comment213121>

    s/Ok../Now/



src/master/master.cpp (line 4056)
<https://reviews.apache.org/r/51320/#comment213123>

    implement the CHECK.



src/messages/messages.proto (line 306)
<https://reviews.apache.org/r/51320/#comment213122>

    wrap in back ticks?


- Vinod Kone


On Aug. 23, 2016, 5:11 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51320/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 5:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6045
>     https://issues.apache.org/jira/browse/MESOS-6045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This operation is all-or-nothing, in that all tasks must be
> launched together. If the operation fails, all tasks will
> fail with TASK_ERROR and the appropriate GROUP reason.
> If a task was killed before delivery to the executor, all
> tasks are killed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 53b6547281b23ce9f47c9f1a418b60667fb4f602 
>   include/mesos/v1/mesos.proto f6b59e156c92a26dd63b11bf403bdba677b9644b 
>   src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8 
>   src/messages/messages.proto 7b5e24fb1e9baf09ce024daeca90745f380d4c2f 
> 
> Diff: https://reviews.apache.org/r/51320/diff/
> 
> 
> Testing
> -------
> 
> Added a test in the subsequent patch.
> 
> More tests will be added for all-or-nothing validation / authorization paths.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message