mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50836: Made add/subtract resource object as private method.
Date Tue, 23 Aug 2016 22:19:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50836/
-----------------------------------------------------------

(Updated 八月 23, 2016, 10:19 p.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Repository: mesos


Description
-------

We do not want people call add/subtract resoure object directly,
so should make those methods as private.


Diffs (updated)
-----

  include/mesos/resources.hpp bdbe8ea03a50cd1361640bde13a2342909723fc5 
  include/mesos/v1/resources.hpp c05cb634c7a5add78da00cb84fc75d3472a341bc 
  src/common/resources.cpp 96b4c39507bdb9b88aca5c2178b88057a5fc1881 
  src/v1/resources.cpp 3cc7580d5567370530c53759713be05c369bf298 

Diff: https://reviews.apache.org/r/50836/diff/


Testing
-------

make
make check

```
./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
./bin/mesos-tests.sh --gtest_filter="SharedResourcesTest.*"
```


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message