mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51316: Documented 'Kill' behavior for task groups.
Date Tue, 23 Aug 2016 19:20:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51316/#review146561
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/scheduler/scheduler.proto (lines 289 - 293)
<https://reviews.apache.org/r/51316/#comment213063>

    How about:
    
    // If the task belongs to a task group, the kill behavior is as follows:
    //
    // If the task group hasn't been delivered to the executor, killing of
    // any task will result in all tasks in the task group being killed.
    //
    // If the task group has been delivered to the executor, it is up to the
    // executor to decide how to deal with the kill. The default Mesos executor
    // will kill all the tasks in the task group if it gets a kill for any task.



include/mesos/v1/scheduler/scheduler.proto (line 281)
<https://reviews.apache.org/r/51316/#comment213064>

    see above.


- Vinod Kone


On Aug. 23, 2016, 5:11 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51316/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 5:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto ac5bce993a586e1794743a098692d77fe0f3f5ac 
>   include/mesos/v1/scheduler/scheduler.proto 05ff0e15bd1c0c607d6fd1d261a95013797a2dad

> 
> Diff: https://reviews.apache.org/r/51316/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message