mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50701: Added registrar operations for marking agents (un-)reachable.
Date Tue, 23 Aug 2016 15:39:18 GMT


> On Aug. 22, 2016, 7:39 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 1907
> > <https://reviews.apache.org/r/50701/diff/2/?file=1471692#file1471692line1907>
> >
> >     do you want to get rid of this parameter (in a different review and for all
operations) because this is no longer configurable?

Yep, definitely: I want to remove all the `registry_strict` stuff, here and throughout the
master: https://issues.apache.org/jira/browse/MESOS-5951

I'm planning to do that once the main functional changes are landed, though.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50701/#review146394
-----------------------------------------------------------


On Aug. 12, 2016, 12:22 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50701/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added registrar operations for marking agents (un-)reachable.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
>   src/tests/registrar_tests.cpp 9a71d8fd0c8d8e662a5e364015d144396a0b1a4c 
> 
> Diff: https://reviews.apache.org/r/50701/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message