mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51317: Documented a bug with the use of `pendingTasks` in the master.
Date Tue, 23 Aug 2016 08:45:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51317/#review146492
-----------------------------------------------------------




src/master/master.cpp (line 3362)
<https://reviews.apache.org/r/51317/#comment212969>

    The current logic is that the task with duplicate ID will be ignored and will not be launched,
so which task will trigger and where do we send out the TASK_ERROR message?
    
    I saw that the TASK_ERROR message will only be sent out if the task is killed in `pendingTasks`
and invalid.



src/master/master.cpp (line 3364)
<https://reviews.apache.org/r/51317/#comment212971>

    Just a question here: Why do you want to distinguish the difference between duplicate
TaskID and getting killed while pending? What is the relatinonship of those two?



src/master/master.cpp (line 3366)
<https://reviews.apache.org/r/51317/#comment212973>

    I saw that this only occur if the task authorization failed for now, shall we highlight
this in the comments here?



src/master/master.cpp (lines 3765 - 3767)
<https://reviews.apache.org/r/51317/#comment212976>

    What about put more detail around line 3807 for `invalid` task case by adding a `TODO`?
    
    ```
    // TODO(bmahler): Validate the task. We may send TASK_ERROR
    // after a TASK_KILLED if a task was killed (removed from
    // `pendingTasks`) *and* the task is invalid here.
    ```



src/master/master.cpp (line 3767)
<https://reviews.apache.org/r/51317/#comment212975>

    Do we need to put `unauthorized` in `TODO`? I saw it aws already handled in line 3774
and 3793.


- Guangya Liu


On 八月 23, 2016, 5:11 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51317/
> -----------------------------------------------------------
> 
> (Updated 八月 23, 2016, 5:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The use of `pendingTasks` cannot distinguish between a duplicate
> TaskID and a task that has been killed while pending. This means
> that if an invalid or unauthorized task is killed while pending,
> TASK_KILLED is sent, and once in Master::_accept, we will also
> send TASK_ERROR.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8 
> 
> Diff: https://reviews.apache.org/r/51317/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message