mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 51319: Removed a hard CHECK for ExecutorInfo.framework_id.
Date Tue, 23 Aug 2016 05:11:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51319/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Removed a hard CHECK for ExecutorInfo.framework_id.


Diffs
-----

  src/master/validation.cpp 30319e75d77546754cdc1f39a8a7c5f9d267e80c 
  src/tests/master_validation_tests.cpp e1a5030d0ec8db978df7f785e3a842b1e81f0d5b 

Diff: https://reviews.apache.org/r/51319/diff/


Testing
-------

Also added an explicit test to ensure that the filling in
functions correctly. This was captured by most other tests,
but wanted to have one that was responsible for testing only
this behavior.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message