mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51270: Added master validations for TaskGroup.
Date Tue, 23 Aug 2016 03:01:28 GMT


> On Aug. 22, 2016, 3:33 p.m., Guangya Liu wrote:
> > src/master/validation.hpp, line 123
> > <https://reviews.apache.org/r/51270/diff/1/?file=1480253#file1480253line123>
> >
> >     Why does this `only exposed for testing.`? I saw that those APIs are not used
for testing but doing some validation when launching task groups.

see comment in the dependent review.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51270/#review146356
-----------------------------------------------------------


On Aug. 21, 2016, 11:29 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51270/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2016, 11:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6042
>     https://issues.apache.org/jira/browse/MESOS-6042
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The TaskGroup is considered invalid if any of the tasks or the executor
> is invalid.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp fd00609df483930d9f749ce764830129da9e8a2c 
>   src/master/validation.cpp ddc7ac3965c93138a38fe3c79776173c610393d6 
>   src/tests/master_validation_tests.cpp ad89812a55fa56c2e13e2a683e35f777dc6341a9 
> 
> Diff: https://reviews.apache.org/r/51270/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message