mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51248: Refactored task validations in master.
Date Tue, 23 Aug 2016 01:32:24 GMT


> On Aug. 22, 2016, 2:30 p.m., Guangya Liu wrote:
> > src/master/validation.hpp, line 80
> > <https://reviews.apache.org/r/51248/diff/1/?file=1480250#file1480250line80>
> >
> >     I saw that many comments are saying that those are `only exposed for testing.`,
but they are actully used in source code but not test.

this is trying to convey that this function is exposed in the header so that it can be tested.
if not for testing, this would only be declared in the source file.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51248/#review146328
-----------------------------------------------------------


On Aug. 21, 2016, 11:28 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51248/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2016, 11:28 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6042
>     https://issues.apache.org/jira/browse/MESOS-6042
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored in such a way that most of the helper functions can be
> reused for doing task group validation.
> 
> Note that there are no functional changes here only code movement.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp fd00609df483930d9f749ce764830129da9e8a2c 
>   src/master/validation.cpp ddc7ac3965c93138a38fe3c79776173c610393d6 
>   src/tests/master_validation_tests.cpp ad89812a55fa56c2e13e2a683e35f777dc6341a9 
> 
> Diff: https://reviews.apache.org/r/51248/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message