mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50423: Avoided using integers as booleans.
Date Mon, 22 Aug 2016 23:34:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50423/
-----------------------------------------------------------

(Updated 八月 22, 2016, 11:34 p.m.)


Review request for mesos, Benjamin Mahler, Gilbert Song, and Jie Yu.


Repository: mesos


Description
-------

This is a follow up action for https://reviews.apache.org/r/49352/,
we should avoid using integers as booleans in favor of explicitly
checking the condition we care about.


Diffs (updated)
-----

  src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
  src/slave/containerizer/mesos/containerizer.cpp 1cd3b3831feefeef6ab2ade6e3f33ecdbd971ecd


Diff: https://reviews.apache.org/r/50423/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message