mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".
Date Mon, 22 Aug 2016 19:43:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50702/#review146419
-----------------------------------------------------------


Fix it, then Ship it!





docs/monitoring.md (line 362)
<https://reviews.apache.org/r/50702/#comment212849>

    s/this was/this/



src/master/metrics.hpp (lines 183 - 184)
<https://reviews.apache.org/r/50702/#comment212850>

    can you add this to the CHANGELOG for 1.1 under "Deprecations" section?


- Vinod Kone


On Aug. 12, 2016, 12:32 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50702/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 12:32 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master will shortly be changed to no longer shutdown unhealthy
> agents, so the previous metric name is no longer accurate. The old
> metric names have been kept for backwards compatibility, but they
> are no longer updated (i.e., they will always be set to zero).
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md e19ecd0ad23538da288577da0237d067459aa7ba 
>   src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
>   src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
>   src/master/metrics.cpp 88a752dc2b4b73ccb919e99478b9ea2bd83842a0 
>   src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
>   src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 
> 
> Diff: https://reviews.apache.org/r/50702/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message