mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51129: Renamed `JNIMesos` to `V1Mesos` for scheduler shim.
Date Mon, 22 Aug 2016 18:04:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51129/#review146389
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Aug. 16, 2016, 4:22 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51129/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2016, 4:22 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5788
>     https://issues.apache.org/jira/browse/MESOS-5788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change renames `JNIMesos`, v1 implementation for the scheduler
> shim to `V1Mesos`. `JNIMesos` was non-intuitive for users considering
> the implementation was already in the native code for `V0Mesos` also.
> Also, it was a bit confusing that `JNIMesos` referred to using the v1
> API under the hood.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/examples/java/V1TestFramework.java a41edbc6a05afd260741ec07bdbdf9d0175db40e 
>   src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp e197b3762024ae6d61ee948997a8bcd098c0d4f5

>   src/java/src/org/apache/mesos/v1/scheduler/JNIMesos.java fc804a4877f444138495cf83eb7b33613a82f345

> 
> Diff: https://reviews.apache.org/r/51129/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message