mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 51068: Prevent memory leaks
Date Fri, 19 Aug 2016 04:08:55 GMT


> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote:
> > Hey Aaron, I was not able to identify the leaks you were addressing. Also there
seems to be some object lifetime issues introduced with this patch.

It looks like I was wrong about this, I had thought the copy constructor of tuple was getting
called when it wasn't the copy constructor at all. I did some more testing with this and found
that the original version behaves properly.
I think we can close this out.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51068/#review145930
-----------------------------------------------------------


On Aug. 17, 2016, 6:21 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51068/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This should prevent any of the promises that are created in the various ZookeeperProcess
class methods from leaking memory.
> 
> 
> Diffs
> -----
> 
>   docs/contributors.yaml 3f06000 
>   src/zookeeper/zookeeper.cpp e105377 
> 
> Diff: https://reviews.apache.org/r/51068/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message