mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 49063: Updating formatting of some lambda calls for readability.
Date Thu, 18 Aug 2016 22:25:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49063/#review146139
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp (lines 2838 - 2839)
<https://reviews.apache.org/r/49063/#comment212515>

    Could you fix the alignment here?



src/slave/http.cpp (lines 924 - 960)
<https://reviews.apache.org/r/49063/#comment212514>

    Let's leave this as-is.


- Michael Park


On June 27, 2016, 11:23 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49063/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 11:23 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 88a11afeda6b96c337ab84fa1b32ab49724beabc 
>   src/slave/http.cpp 30006c2255ebfc6e2b150d518bc758eb3e94dbca 
> 
> Diff: https://reviews.apache.org/r/49063/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message