mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 36816: Supported HTTP/HTTPS in health check.
Date Wed, 17 Aug 2016 00:44:10 GMT


> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote:
> > src/health-check/health_checker.hpp, line 330
> > <https://reviews.apache.org/r/36816/diff/17/?file=1465465#file1465465line330>
> >
> >     Why do you need to discard original future here?
> 
> haosdent huang wrote:
>     I saw we discard original future in every `after` callback. So I discard it here
as well.
> 
> Alexander Rukletsov wrote:
>     This is may be true. Do you know why we do this?
> 
> haosdent huang wrote:
>     I think it is because the `.then` callback may continue to executed when the `future`
is ready if we don't call `future.discard()`.

That's correct.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review145451
-----------------------------------------------------------


On Aug. 15, 2016, 3:42 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 3:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert
Song, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
>     https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported HTTP/HTTPS in health check.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
>   src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message