mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 49360: Supported TCP in health check.
Date Wed, 17 Aug 2016 00:05:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49360/#review145935
-----------------------------------------------------------




src/health-check/health_checker.cpp (lines 489 - 503)
<https://reviews.apache.org/r/49360/#comment212285>

    Again, we probably want to do it in a subprocess hook. For this, we need to provide a
small binary that does a TCP check : )



src/health-check/health_checker.cpp (lines 510 - 515)
<https://reviews.apache.org/r/49360/#comment212286>

    As per my comment above, let's create a simple binary for that (maybe even without libprocess
dependency) and call it via `Subprocess`.


- Alexander Rukletsov


On Aug. 15, 2016, 3:43 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49360/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert
Song, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3567
>     https://issues.apache.org/jira/browse/MESOS-3567
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported TCP in health check.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 
> 
> Diff: https://reviews.apache.org/r/49360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message